[IDEV-2572] domaintools v14.0: Address Bugbash Feedbacks - #4
Merged
Conversation
|
❌ Integration Tests Failed Click to view the full report🧩 domain_tools
❌ Failed Teststests/test_actions/test_enrich_domain_risk.py::TestEnrichDomainRisk::test_young_domain_marked_suspicious |
jbabac
approved these changes
Aug 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Address Bugbash Feedback: enrichment expansion, suspicious flag fixes, and missing domain reporting
Please use a clear and concise title that summarizes your changes.
If this PR is related to an internal Buganizer ticket, please include its ID at the beginning.
were flagged alongside their risk category
young domains were always marked suspicious regardless of their score
result so nothing silently goes missing
domain list with case entities in a single run
now capture significantly more fields including expiration date,
registrant/registrar details, hosting info, tracking codes, contacts, redirect
info, and tags
count alongside the value
scored above the threshold but drops below it, the flag is now removed instead of
staying stuck
Description
Please provide a detailed description of your changes. This helps reviewers understand your work and its context.
What problem does this PR solve?
The DomainTools integration lacked three new enrichment actions (EnrichDomainRisk, BulkEnrichDomains, GetDomainProfile), had several bugs in the existing actions (wrong license check on GetWhoIsHistory, construct_csv imported from the wrong module, suspicious flag never cleared on re-run), and returned limited data from the API as it has missing fields like registrant details, hosting info, tracking codes, contacts, redirect info, and expiration dates.
How does this PR solve the problem?
full field mapping into typed datamodels
response including contacts, tracking codes, tags, hosting, and registration
fields
and always re-evaluated on each run so stale flags are cleared
by the API are surfaced in the output instead of silently dropped
combining a manual domain list with in-scope case entities
top-level TIPCommon package
Any other relevant information (e.g., design choices, tradeoffs, known issues):
Checklist:
Please ensure you have completed the following items before submitting your PR.
This helps us review your contribution faster and more efficiently.
General Checks:
Open-Source Specific Checks:
For Google Team Members and Reviewers Only:
Screenshots (If Applicable)
N/A
Further Comments / Questions
N/A